elm-d3 icon indicating copy to clipboard operation
elm-d3 copied to clipboard

support for elm 0.17.x

Open francisdb opened this issue 8 years ago • 16 comments

the title says it all, anybody working on this already?

francisdb avatar Jul 05 '16 22:07 francisdb

Just came across some spare beach time on the Mediterranean, so I'll be working on it over the weekend.

seliopou avatar Jul 08 '16 15:07 seliopou

Fixing this should fix #32.

seliopou avatar Jul 08 '16 15:07 seliopou

great, enjoy the 🏖

francisdb avatar Jul 08 '16 15:07 francisdb

I'm going to keep a bit of a journal of the process here, both to help others that may have to do a port like this in the future, and certainly to keep things straight in my head right now.

seliopou avatar Jul 08 '16 16:07 seliopou

@seliopou I started to do some migration myself... but having difficulty turning signals into subscriptions

There was also some conflict as to using Native code (as you have chosen) or Ports.

mango314 avatar Jul 08 '16 18:07 mango314

@seliopou any progress?

francisdb avatar Jul 15 '16 21:07 francisdb

I was hoping to leverage your awesome library to showcase Elm 0.17 with some work related stuff. Do you think you could provide an ETA on this? I'd prefer the library rather than peddle with ports :)

ffos avatar Jul 29 '16 00:07 ffos

Sorry for the radio silence. I did some digging into the current state of Elm's native interfaces, and the situation is not great with respect to a speedy port to 0.17. Essentially, everything about the runtime has changed, which means that this will likely be a significant lift. That will be a bit of coding for sure, but even before getting to that I have to identify how to surface native events to application code, and also providing a custom rendering function. I'll look a bit more tonight, but being realistic here, I wouldn't expect a quick turnaround.

If anybody has any pointers, I'm all ears.

seliopou avatar Jul 29 '16 00:07 seliopou

Thank you for the update - helps me prioritize stuff on my end.

ffos avatar Jul 29 '16 02:07 ffos

@seliopou Can you outline the "Elm's native interface" changes that affect elm-d3? I.e. what are the tasks required to migrate up?

jadbox avatar Sep 15 '16 04:09 jadbox

Edit: @MonsieurCactus mentioned the issue (and possible solutions) with native code on a pull request.

@hoelzro wrote a great article about a migration from 0.16 to 0.17

@jadbox, I think @seliopou is referring to how elm-d3 uses the JavaScript files located in this directory

It seems that the native API changes very quickly and it is not recommended

rvazquezglez avatar Nov 10 '16 07:11 rvazquezglez

As long as the work is more or less mechanical / testing I can also help out.

francisdb avatar Nov 10 '16 08:11 francisdb

@francisdb the mechanical part (syntax changes, dependency versions update) was already done by @MonsieurCactus. As I see, these are the steps required:

  1. Change the native code to ports (requires understanding of both)
  2. Change the uses of Signal to Commands (this was a conceptual change introduced in 0.17)

rvazquezglez avatar Nov 10 '16 18:11 rvazquezglez

0.18?

l0rinc avatar Jan 29 '17 16:01 l0rinc

Looking to use elm + d3 for a project i'm about to begin work on... Is there any status update on this (0.18 compatibility now)?

I'm also happy to help w/ any mechanical / testing work to be done.

clevinson avatar May 10 '17 13:05 clevinson

@clevinson what would you like to see in a port from Elm to D3? Elm is not at v0.18 and D3 is not at v4. Therefore I might open a new issue.

I noticed I am approximate many of D3's canvas and SVG features purely within Elm. Not 100% of systematically. I have considered going back to work on this.

mango314 avatar May 22 '17 14:05 mango314