Fix ODT exporting tables

Open eduardomozart opened this issue 2 years ago • 3 comments

Fixes #272

Nov 28 '23 13:11 eduardomozart

It fails in 4 tests and you changed null to 0cm, maybe "null" works better.

Nov 28 '23 14:11 nerun

It shouldn't be null because null isn't a valid CSS value for margin. In fact, if you see the lines 710-717, you'll see that for the problem you're facing (float is null), the code set the margins to 0cm. I just set it directly to 0cm to avoid code changes, but you're free to change the float detection and variable assignments if you will and commit a PR to the code.

Nov 28 '23 14:11 eduardomozart

Submited PR #275, but same errors, same tests.

Nov 28 '23 14:11 nerun