dokuwiki_plugin_wrap icon indicating copy to clipboard operation
dokuwiki_plugin_wrap copied to clipboard

use default styles in pdf.less

Open micgro42 opened this issue 6 years ago • 4 comments

This allows to show the default styles in pdf documents created with dw2pdf without having to use explicitly add wrap to the screen styles enabled dwpw2pdf config option.

The import is place outside of the .dokuwiki selector, since style.less already includes .dokuwiki selectors itself. For consistency the import of print_or_pdf.less is also moved outside of the selector.

micgro42 avatar Mar 29 '18 15:03 micgro42

However, I'm not really sure why the .dokuwiki selectors are necessary in the first place. Shouldn't specificity be high enough without them?

micgro42 avatar Mar 29 '18 15:03 micgro42

Ah, thanks. That explains why it wasn't working for me. But this is not fully working either, the icons for the boxes and the background colour for the default box are missing and the spoiler is showing. (That is when DW2PDF's usestyles is empty.) Weird, why would the result be any different to what's showing now with splitbrain/dokuwiki-plugin-dw2pdf#325 in place?

The .dokuwiki class is not there for specificity but for scoping the CSS so that it cannot interfere with CSS not coming from DokuWiki. It's further described on https://www.dokuwiki.org/devel:templates#dokuwiki_class.

selfthinker avatar Mar 29 '18 19:03 selfthinker

I just realised what the pattern is. Apart from the images not loading, it is all the classes which include CSS color placeholders which are not working! E.g. the plain box includes __background_alt__ and __text__.

selfthinker avatar Mar 31 '18 11:03 selfthinker

I fixed the color placeholders not working in #172 as suggested in splitbrain/dokuwiki-plugin-dw2pdf#325. It's still outstanding that the background images are not working. I'd rather not use the hacky solution suggested in the DW2PDF issue above.

selfthinker avatar Apr 15 '18 15:04 selfthinker