show-notes icon indicating copy to clipboard operation
show-notes copied to clipboard

Add search.share feature

Open Southporter opened this issue 2 years ago • 4 comments

Having a sharable link would be nice to post into chats and such.

Southporter avatar May 17 '22 14:05 Southporter

We currently run on mkdocs 7.1.9, so this feature sadly isn't available. It would need upgrading before that became available for use.

RealOrangeOne avatar May 17 '22 20:05 RealOrangeOne

We currently run on mkdocs 7.1.9

Is there anything preventing us from updating? I bumped to 7.2.8, served locally, and poked around to make sure nothing was broken. Looks to be fine.

Southporter avatar May 18 '22 14:05 Southporter

You will also need to update the production build: https://github.com/selfhostedshow/show-notes/blob/main/.github/workflows/scrape.yml#L66

RealOrangeOne avatar May 18 '22 17:05 RealOrangeOne

Ahh, yeah, didn't think to check that. I've updated the Dockerfile as well.

Southporter avatar May 18 '22 18:05 Southporter

Finally got round to testing this out. Nice one!

ironicbadger avatar Dec 31 '22 16:12 ironicbadger