web-app
web-app copied to clipboard
selfdefined
Fluid type scale
- Creates a fluid type scale.
- Provides a convenient config map and a mix-in to programatically generate all the css custom properties required for creating and using a type scale. The methods employed are inspired the following sources( https://every-layout.dev/rudiments/modular-scale/ ). Thanks to @tbrasington and @ovlb for the help and inspiration!
- Replaced all 'raw' font-sizes with fluid scales. Please let me know if the scales need more refining
Further improvements possible:
- [ ] add clamps for every fontsize used ( need to decide with the help of a designer )
- [x] Create scales for line-height too
Thank you @tbrasington for the updates to line-height and refining scales!
@ovlb Feel free to approve this if you and @tbrasington are good with it!
@codeAbul FYI: I already had a look and overall it looks fine. I’ll write a review that’s worthy of your effort tomorrow, promised!
The foundation is solid and in a good place to be extended it as the new features get built out.
As a side note, what may be needed next is guides on pairings of steps and styles.
@ovlb Thank you for the reviews. I shall address them this weekend. Sorry, been busy with stuff! Thanks again
@codeAbul Checking in to see if you're still interested and able to close out this PR. As far as I can tell we're very close!
Hi @tatianamac i am so sorry I have left this out in the wind , thanks to the mess of pandemic and job change. I will work on this tonight. Again sorry for the delay. Hope you and yours are keeping well, as well as one can be in these times.
@codeAbul : Hello! A no-pressure check to see how you're feeling about this PR (I'm going through all issues). Are you still interested in finishing it out? (It might very well be finished; it's hard for me to tell for certain).