krux icon indicating copy to clipboard operation
krux copied to clipboard

GPG ECDSA secp256k1 Keys and Signatures

Open odudex opened this issue 8 months ago • 1 comments

What is this PR for?

  • Add GPG ECDSA secp256k1 Keys and signatures as e BIP85 feature
  • Standardize navigation on BIP85 menu

Changes made to:

  • [x] Code
  • [ ] Tests
  • [ ] Docs
  • [ ] CHANGELOG

Did you build the code and tested on device?

  • [x] Yes - Amigo

What is the purpose of this pull request?

  • [ ] Bug fix
  • [x] New feature
  • [ ] Docs update
  • [ ] Other

odudex avatar May 07 '25 16:05 odudex

Codecov Report

:x: Patch coverage is 1.21951% with 81 lines in your changes missing coverage. Please review. :white_check_mark: Project coverage is 96.63%. Comparing base (e6b895e) to head (db8c145).

Files with missing lines Patch % Lines
src/krux/pages/home_pages/gpg_ui.py 0.00% 73 Missing :warning:
src/krux/pages/home_pages/bip85.py 11.11% 8 Missing :warning:

:x: Your patch check has failed because the patch coverage (1.21%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #595      +/-   ##
===========================================
- Coverage    97.37%   96.63%   -0.75%     
===========================================
  Files           83       84       +1     
  Lines        10525    10607      +82     
===========================================
+ Hits         10249    10250       +1     
- Misses         276      357      +81     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar May 07 '25 17:05 codecov[bot]