krux icon indicating copy to clipboard operation
krux copied to clipboard

Check and inform if wallet output descriptor has change addr

Open tadeubas opened this issue 9 months ago • 2 comments

What is this PR for?

@qlrd noticed while improving tests that an wallet output descriptor without info on change derivation index would show the same addresses as receive index.

  • Wallet Descriptor now validates and warns if it was unable to determine change addresses.
  • Hide change address menu option when index not available.

Note: this PR is assuming that embit is correct for miniscript, so this embit PR needs to be merged beforehand - https://github.com/diybitcoinhardware/embit/pull/74

Changes made to:

  • [x] Code
  • [x] Tests
  • [ ] Docs
  • [x] CHANGELOG

What is the purpose of this pull request?

  • [ ] Bug fix
  • [ ] New feature
  • [ ] Docs update
  • [x] Other

tadeubas avatar Apr 09 '25 14:04 tadeubas

Neat!

odudex avatar Apr 09 '25 14:04 odudex

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 95.43%. Comparing base (5362607) to head (66f2c3d). Report is 1 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #561      +/-   ##
===========================================
+ Coverage    95.42%   95.43%   +0.01%     
===========================================
  Files           76       76              
  Lines         8696     8703       +7     
===========================================
+ Hits          8298     8306       +8     
+ Misses         398      397       -1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Apr 11 '25 08:04 codecov[bot]

https://github.com/diybitcoinhardware/embit/pull/76 has been merged into Embit's develop branch. Can you fix conflicts on Krux's PR so it can be merged?

odudex avatar May 06 '25 11:05 odudex

As I had to fix a conflict, I've also removed \r\n from tests

tadeubas avatar May 06 '25 14:05 tadeubas

Thank you!

odudex avatar May 06 '25 16:05 odudex