Schuyler Eldridge

Results 201 comments of Schuyler Eldridge

Thanks for taking the time to report this! :+1: I think these can be cleaned up. That `requirement failed` error is pretty egregious. One clarification: is the concern here just...

> You have mentioned that you get a shorter output locally and I don't know why this is. I thought the chisel-template (at the mentioned commit) should more or less...

This was discussed in the developer meeting today with two proposals put forward: 1. One or more new methods should be added to `ChiselMain` to allow for users to pass...

To clarify: the bug is that the SFC should reject this circuit because `rem(UInt, SInt)` is illegal. This has to be either `rem(UInt, UInt)` or `rem(SInt, SInt)`. `CInferTypes` is crashing...

Would it make sense to just define two latencies as opposed to having a bool choose between two interpretations of the same parameter? It's more verbose, but less confusing possibly.

Eventually, yes. However, it doesn't have to be captured in Chisel or FIRRTL, just defining (or changing) how the existing Chisel and FIRRTL simplistic read/write latencies are lowered to the...

> The naive approach is not great, such an approach can lead to missed issues... That's my worry, too. > Could we write a wrapper around random number generation that...

Two things: (1) Whatever is causing these to hit `LowerToHW` should be investigated as an SFC-compliant pass pipeline shouldn't be allowing these to live beyond `SFCCompat`. (Perhaps there should be...

This is coming together nicely. It is worthwhile to think about what the semantics of this op should be for FIRRTL. I'm of the opinion that a valid FIRRTL XMR...

> Should there be a corresponding change to firrtl spec for this? Eventually, yes. This PR is, right now, just for CIRCT-internal usage to better model XMR concepts which are...