seladb

@clementperon any idea why the build would fail? @zyl-one can you please post the output of how you build PcapPlusPlus?

@zyl-one just to make sure I understand: the code above works fine with v23.09 but doesn't work with the latest code in `master`? The error that you mentioned: `error calling...

@zyl-one can you please help us debug the issue as @Dimi1010 suggested in https://github.com/seladb/PcapPlusPlus/issues/1533#issuecomment-2293504797 ?

@prudens can you please address the review comments, and also resolve the conflicts in ` Tests/Pcap++Test/Tests/TcpReassemblyTests.cpp`?

@prudens we added clang-format so you need to run it on your code. Here how to install clang-format: https://github.com/seladb/PcapPlusPlus/blob/0a843116d6f679f6dcc9f9c3c002ca94b32c227f/.github/workflows/build_and_test.yml#L33 ```shell python3 -m pip install cmake-format clang-format==18.1.6 ```

@prudens can you please address these 2 comment: - https://github.com/seladb/PcapPlusPlus/pull/1496#discussion_r1683714487 - https://github.com/seladb/PcapPlusPlus/pull/1496#discussion_r1683963061

@jmckaskill I'm not sure I understand. Why do we need fsync here? 🤔

@Dimi1010 @tigercosmos @egecetin @clementperon let's discuss this change: if we want to move away from the existing tests infra I think it should be a consternated effort to migrate all...

> @seladb What is the expected date of the new release? If it will be about 25.04 it is easy to work on it by planning. The more important question...

> I think it will be beneficial overall. The rollout can be done in phases (project by project) similar to the way we did the clang-format roll out. I could...