seladb
seladb
thank you! should we keep this issue open to track it?
btw, I can work on that also, but I'll need some guidance from you on where to start
@Malix-off I'm not sure StarTrack is suitable to be a GitHub App because it doesn't have a backend. It has no way to store the private key and the client...
@Malix-off if it works I think it could be a nice addition to StarTrack! Once you finish experimenting on your app, could you share your findings? Maybe you can consider...
@rtmeng do you plan to continue working on this PR?
> @seladb could you help me with the Tests? I'm confusing now.... @MCredbear I'm looking...
@MCredbear I looked into why the tests don't pass and I'm working on a fix. The main problem with calling `closeConnection()` inside `onMessageReadyCallback` is that it may cause a recursive...
@MCredbear please take a look at the changes I made in this commit: https://github.com/seladb/PcapPlusPlus/pull/1346/commits/bdf16164177dfdff2f33c2350752dcaeba144b9e All tests pass now.
@MCredbear did you see my previous comments? Let me know if we can merge the PR
Thank you @MCredbear for working on this, much appreciated! 🙏 ❤️