seladb
Relative time axis
This is still only a proof of concept, to get feedback on the architecture.
Issue: #200
Hi @seladb, did you have a chance to look at it yet?
@fdw I'm sorry, I probably missed it somehow, thanks for checking in! I'll take a look in a few days, sorry again for the long delay
I've changed the code according to your suggestion. Only thing missing now is a different icon. Where did you get the others from?
I've changed the code according to your suggestion. Only thing missing now is a different icon. Where did you get the others from?
To be honest, I'm not sure where I got the buttons for log and linear scale... but maybe LLM can generate something?
Also - can you add tests for it in Chart.test.tsx?
Please also notice that the existing tests fail now...
To be honest, I'm not sure where I got the buttons for log and linear scale... but maybe LLM can generate something?
I found out that the existing icons are from FontAwesome, and added new ones from there. Hope this is right like this 🙂 (Do I need to add some attribution somewhere?)
Please also notice that the existing tests fail now...
Sorry, forgot about the tests. Should be fixed now.
Also - can you add tests for it in Chart.test.tsx?
Done 🙂
@fdw the Playwright tests are still failing and also coverage is down by 0.2%. Do you think you can fix those?
I added a test to cover one additional line 😉
However, I have no idea what's wrong with the Playwright tests. Looking at the log, most of them simply timed out and others failed even though I have not changed anything related to the code they test. If you have a clue, please share. Otherwise, I hope that the next run will be better.
@fdw I found a bug: when hovering over the chart, the data is Nan, you probably need to change the hovertemplate
Thank you so much @fdw for working on this change, much appreciated! 🙏
I'll create a new release soon to contain this new change