PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard

Published 20 hours ago • verified publisher icon seladb

Add SOME/IP protocol

Open kolbex opened this issue 3 years ago • 10 comments

Add SOME/IP layer support

  • Add SomeIPLayer class for handling SOME/IP packets
  • Support for crafting and parsing packets
  • Add tests
  • Update README.md file

SOME/IP TP and SOME/IP SD support will follow in separate PRs.

kolbex avatar May 30 '22 10:05 kolbex

@seladb can you please restart build?, we tried to fix a regression, however it seams now an unrelated memory leak check fired.

guebe avatar Jun 01 '22 11:06 guebe

Done!

seladb avatar Jun 01 '22 14:06 seladb

Done!

@seladb thx. We cant reproduce the regressions locally. We tried both locally mingw-w64 and vs 2019 release. But all tests are passing locally using those compilers. Perhaps I am using other flags or other settings as the build machine, I dont know. Is there a way to get the build artifacts (Packet++Test.exe, ...) from the test system, so we can debug them locally? Do you have other suggestions? It would be really nice to have the failing executables. Otherwise I would have to change tests to add more debugging code.

guebe avatar Jun 02 '22 09:06 guebe

@seladb can you please approve the workflow. Also this PR is ready for review, how should we proceed?

kolbex avatar Jun 13 '22 10:06 kolbex

SOME/IP TP and SOME/IP SD support will follow in separate PRs.

Would be cool to see or to, at least, understand how do you plan to parse SD messages.

miketsukerman avatar Jun 13 '22 17:06 miketsukerman

SOME/IP TP and SOME/IP SD support will follow in separate PRs.

Would be cool to see or to, at least, understand how do you plan to parse SD messages.

Our preference would have been to base the PRs for adding SOME/IP-SD and SOME/IP-TP on origin/dev as soon as the plain SOME/IP PR is merged, but if it makes review easier for you, we can also already create the PRs and base them on the plain SOME/IP PR branch. Please let me know what you would prefer, so we know whether we should create the PRs already. Thanks

maruu avatar Jun 14 '22 08:06 maruu

SOME/IP TP and SOME/IP SD support will follow in separate PRs.

Would be cool to see or to, at least, understand how do you plan to parse SD messages.

Our preference would have been to base the PRs for adding SOME/IP-SD and SOME/IP-TP on origin/dev as soon as the plain SOME/IP PR is merged, but if it makes review easier for you, we can also already create the PRs and base them on the plain SOME/IP PR branch. Please let me know what you would prefer, so we know whether we should create the PRs already. Thanks

I am okay with the idea to finish current MR first. But, in theory, you can also split changes into several commits even in this MR. But, well, up to you.

On the other hand, if you would add SD messages processing, I could try to test it.

miketsukerman avatar Jun 23 '22 19:06 miketsukerman

@seladb @miketsukerman this PR is ready for review. I also upstreamed our implementation of SOME/IP-TP in a second PR. It is also ready for review. The implementation for the SOME/IP-SD will quickly follow.

kolbex avatar Jul 15 '22 12:07 kolbex

@seladb thx for the review, i currently will focus on NDP/ICMPv6 so there will be no progress here the next week

kolbex avatar Jul 18 '22 13:07 kolbex

@seladb thx for the review, i currently will focus on NDP/ICMPv6 so there will be no progress here the next week

Sure, no problem at all! Thanks for your ongoing contribution to this project!

seladb avatar Jul 19 '22 08:07 seladb