PcapPlusPlus icon indicating copy to clipboard operation
PcapPlusPlus copied to clipboard
verified publisher icon seladb

Visual Studio 17.8 build failure

Open davidbolvansky opened this issue 1 year ago • 4 comments

Newer Visual Studio 17.8+ C++ STL deprecates the use of checked_array_iterator with this change https://github.com/microsoft/STL/pull/3818

This causes a build error due to the deprecation if warnings are treated as errors.

davidbolvansky avatar Sep 17 '24 12:09 davidbolvansky

@davidbolvansky Thanks for the information. We will consider to make a patch for it. Feel free to submit a PR as well!

tigercosmos avatar Sep 17 '24 13:09 tigercosmos

Workaround for now: add_compile_options(-D_SILENCE_STDEXT_ARR_ITERS_DEPRECATION_WARNING)

davidbolvansky avatar Sep 17 '24 13:09 davidbolvansky

Nice, but it's better to address it from the source.

tigercosmos avatar Sep 19 '24 00:09 tigercosmos

@davidbolvansky could you point which VLA is causing the issue ?

Maybe you can open a MR and follow what has been done for FreeBSD https://github.com/seladb/PcapPlusPlus/pull/1588/commits/e5f6911c5337ee47d804fd4fe3f4a299dce2c79b

clementperon avatar Oct 05 '24 15:10 clementperon

@davidbolvansky are you sure this is still happening?

We're using windows-2022 in our CI which uses Visual Studio 17.13 and the build passes 🤔

seladb avatar Mar 30 '25 22:03 seladb

@davidbolvansky I'll close this issue now; if the issue persists, please feel free to re-open it

seladb avatar Apr 10 '25 09:04 seladb