zimg Add `use_scene_referred` to `zimg_graph_builder

Add `use_scene_referred` to `zimg_graph_builder_params`

Open Setsugennoao opened this issue 1 year ago • 4 comments

As the title says, adds this param to the public API.

I also edited the test example to include it. I don't know if you didn't want the changelog to be updated, I can remove it ^^

Mar 25 '23 18:03 Setsugennoao

Hi, is there anything I should modify for it to be merged? Is this not planned or wanted in the API?

Jun 29 '23 14:06 Setsugennoao

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

Jun 30 '23 02:06 sekrit-twc

scene_referred will be added when a verified use case arises. Otherwise, there will be much untested code exposed.

The original want for this option stems from this Doom9 thread: https://forum.doom9.org/showthread.php?p=1972723#post1972723

For what it's worth, AVS+ users have had access to this code for approximately a year. I will contact the maintainer to confirm.

Jun 30 '23 10:06 NSQY

No known problems reported with the AVS+ build. Testing may be limited to the aforementioned post.

Jul 02 '23 07:07 NSQY