David Grant

Results 26 comments of David Grant

@dnwe - Still seems valuable, but I left the org where I wanted to do that thing. Don't think they needed to do that, either.

Awesome. I would imagine persistent TCP conns would help quite a bit. UDP seems less desirable with intermittently flaky cloud networking, inability to do TLS, ...

This would be valuable. Tons of big numeric constants embedded in jsonnet out there. This would be a deviation from json, but ECMAScript has digit separators. Would the mods look...

[ECMA proposal](https://github.com/tc39/proposal-numeric-separator), [PEP515](https://peps.python.org/pep-0515/). Differences between the two seem to be: * Python plumbs the support into the standard library, allowing you to do things like `int('123_456')` at runtime. ECMAScript doesn't....

Since that's the only difference I can find, what if we just followed ECMAScript? To put it into words: * Jsonnet numeric literals should support digit separators. * We'll follow...

@dimitarvdimitrov Yes, but higher layers are the culprit. This passage is in the stack above `fetchSeriesFromStores`: https://github.com/grafana/mimir/blob/faf2b84898daf12cc030481af413425667ae9831/pkg/querier/querier.go#L363-L378 There could be more higher up - haven't scrutinized it.