angular-bootstrap-slider icon indicating copy to clipboard operation
angular-bootstrap-slider copied to clipboard

Clicking on the slider line (VS dragging handles) doesn't invoke change of UI using change event

Open crmn111 opened this issue 9 years ago • 3 comments

UI and model are out of sync using the change event, because change event is not invoked on the UI, only the model is adapted. I can see the reason why this is done, because following the bootstrap slider documentation and implementing 'change/onchange' event handler, it generates a warning.

I have resolved this locally by renaming the change event handler onchangeslide.

Now when you click on the slider line (VS dragging the slider handles), which is a common thing to do for a user, both the model and view are updated, as expected.

I will make a pull request for this, also i will change the readme to accommodate the event handlers, if you don't mind?

Which notation of event handlers is preferred? on 'onslide' or 'on-slide' ?

crmn111 avatar Jul 13 '15 09:07 crmn111

it's strange but when i fork this repo i get different code than when i do bower install angular-bootstrap-slider but the version numbers seem to be the same (both 1.3.0)

crmn111 avatar Jul 13 '15 11:07 crmn111

That's because I don't do a git tag that often. See here for event preferences.

seiyria avatar Jul 13 '15 12:07 seiyria

@dirkjan111 Any news on a PR? I think what you're describing might be the source of the problem in #71 ... maybe?

evillemez avatar Sep 15 '15 16:09 evillemez