sei-chain icon indicating copy to clipboard operation
sei-chain copied to clipboard

Reuse the same contract address when upgrading ERC->CW pointers

Open codchen opened this issue 9 months ago • 1 comments

Describe your changes and provide context

Previously pointer contract will be assigned a new address when it's upgraded to a new version, which is quite inconvenient to end users and applications. Since pointer contracts themselves are stateless, it is possible to reuse the same address for a new version of code. This PR implements that for the EVM->CW direction pointers. A similar change will be made for CW->EVM pointers

Testing performed to validate your change

unit test

codchen avatar May 14 '24 06:05 codchen

Codecov Report

Attention: Patch coverage is 61.73469% with 75 lines in your changes missing coverage. Please review.

Project coverage is 61.14%. Comparing base (e8e4b3b) to head (fa9e29c). Report is 106 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1663      +/-   ##
==========================================
- Coverage   61.64%   61.14%   -0.51%     
==========================================
  Files         365      255     -110     
  Lines       26178    22128    -4050     
==========================================
- Hits        16138    13530    -2608     
+ Misses       8967     7624    -1343     
+ Partials     1073      974      -99     
Files Coverage Δ
x/evm/keeper/pointer.go 80.00% <ø> (+1.79%) :arrow_up:
x/evm/gov.go 38.46% <50.00%> (-61.54%) :arrow_down:
x/evm/keeper/view.go 71.42% <71.42%> (ø)
precompiles/pointer/pointer.go 35.07% <16.66%> (+1.74%) :arrow_up:
x/evm/module.go 52.44% <11.11%> (-4.47%) :arrow_down:
x/evm/keeper/pointer_upgrade.go 73.61% <73.61%> (ø)
x/evm/migrations/migrate_all_pointers.go 59.55% <59.55%> (ø)

... and 145 files with indirect coverage changes

codecov-commenter avatar May 14 '24 06:05 codecov-commenter