typewriter icon indicating copy to clipboard operation
typewriter copied to clipboard

React Native support

Open wfortin opened this issue 6 years ago • 6 comments

Hi, I would like to propose typewriter support for @segment/analytics-react-native, it seems that with few small modification to the analytics-node templates, we could add support for it. Would you be open for a PR for this?

wfortin avatar Nov 04 '19 19:11 wfortin

Hey @wfortin! That'd be great! 🎉 If you open a PR, feel free to tag me and I'll take a look.

If you add the changes to templates, it would be great to also add a test for it here: https://github.com/segmentio/typewriter/tree/master/tests/e2e

All it needs is a minimal React Native app, such that it can boot and fire these events. Here's an example from analytics-node.

colinking avatar Nov 04 '19 20:11 colinking

Oof, I didn't think of the e2e tests to cover that. Setting up a proper e2e test infrastructure for react-native can be a pain. I'll see if that is worth the hassle for me to take on 😉 . Thanks for the quick response.

wfortin avatar Nov 04 '19 20:11 wfortin

Sounds good, feel free to ping me if you have any questions!

colinking avatar Nov 04 '19 22:11 colinking

hi @colinking , has there been any further discussion on adding support for @segment/analytics-react-native ? We have a project that would greatly appreciate it.

jonhilmarg avatar Aug 31 '20 14:08 jonhilmarg

It would be really nice to at least get some response from Segment on this. Since our core product is react native, this would have high value for us, so if, like the OP suggests, would only require small changes on top of analytics-node, I'd like to apply a little pressure to get it done. 😘

mpj avatar Oct 07 '20 08:10 mpj

Has anyone been able to make Typewriter work with React Native?

sregg avatar Jul 13 '22 17:07 sregg

v8 has support for RN now. It shows up during typewriter init or you can set the SDK to analytics-react-native in your config file

oscb avatar Sep 12 '22 23:09 oscb