kafka-go icon indicating copy to clipboard operation
kafka-go copied to clipboard

feat: sasl reauthentication

Open ertanden opened this issue 1 year ago • 8 comments

Fixes #1093

Not really familiar with the code base, but I figured out that there are 2 different implementation of the Kafka protocol, so I put the same logic to both "conn.go" and "transport.go".

So far I could only test this with the "Reader" so the code in "conn.go" seems to work.

I tried different percentages, but ended up using a random %80-%90 percent of session lifetime to trigger re-authentication. A static %90 sometimes caused the "stopped heartbeat" problem with rebalances etc...

ertanden avatar Nov 10 '23 15:11 ertanden

any chance this got review?

whirlp00l avatar Feb 18 '24 13:02 whirlp00l

Hello, this PR would be important for us too, can someone review it?

renanrt avatar Mar 03 '24 22:03 renanrt

Hi team, can someone please review this PR? We are observing frequent rebalances into our consumer groups because of this issue.

gurusiddha avatar Jun 24 '24 07:06 gurusiddha

Hi @petedannemann any update on this PR?

lmppalone avatar Jul 04 '24 08:07 lmppalone

Hi @petedannemann Could someone please review this PR? We are experiencing frequent rebalances in our consumer groups due to this issue. cc: @ertanden

lmhuteshmahajan avatar Jul 04 '24 08:07 lmhuteshmahajan

@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups

lmvaibhavshewale avatar Jul 04 '24 09:07 lmvaibhavshewale

@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups

lmvaibhavshewale avatar Jul 04 '24 09:07 lmvaibhavshewale

+1 for waiting on this to get merged. I see there's a required opa policy validation merge check, is that waiting on action from @ertanden to accept a contribution agreement or something before this can be merged?

billcobbler avatar Aug 06 '24 00:08 billcobbler