kafka-go
kafka-go copied to clipboard
feat: sasl reauthentication
Fixes #1093
Not really familiar with the code base, but I figured out that there are 2 different implementation of the Kafka protocol, so I put the same logic to both "conn.go" and "transport.go".
So far I could only test this with the "Reader" so the code in "conn.go" seems to work.
I tried different percentages, but ended up using a random %80-%90 percent of session lifetime to trigger re-authentication. A static %90 sometimes caused the "stopped heartbeat" problem with rebalances etc...
any chance this got review?
Hello, this PR would be important for us too, can someone review it?
Hi team, can someone please review this PR? We are observing frequent rebalances into our consumer groups because of this issue.
Hi @petedannemann any update on this PR?
Hi @petedannemann Could someone please review this PR? We are experiencing frequent rebalances in our consumer groups due to this issue. cc: @ertanden
@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups
@petedannemann can you please review it as we are stuck on the production as We are experiencing frequent rebalances in our consumer groups
+1 for waiting on this to get merged. I see there's a required opa policy validation
merge check, is that waiting on action from @ertanden to accept a contribution agreement or something before this can be merged?