evergreen icon indicating copy to clipboard operation
evergreen copied to clipboard

fix windows build

Open maxrchung opened this issue 1 year ago • 1 comments

Overview I would like to run this project on Windows but encountered some issues trying to run some of the scripts. In this PR, I adjusted a few things to make yarn build and yarn dev work:

  • Change single quotes to escaped double quotes. Based on this concurrently issue it seems Windows treats quotes differently.
  • Use cross-env to set environment variables in script.
  • Use rimraf to remove files.

I verified on my Windows and Mac machines that yarn build and yarn dev were successful after the changes. One thing separately I also noticed was that Node 18 did not seem to be supported, and I had to downgrade to Node 16 in order to run the project.

Screenshots (if applicable) N/A

Documentation

  • [ ] Updated Typescript types and/or component PropTypes
  • [ ] Added / modified component docs
  • [ ] Added / modified Storybook stories

maxrchung avatar Feb 13 '24 19:02 maxrchung

Deploy Preview for evergreen-storybook ready!

Name Link
Latest commit 534253df248a6799cae80a79ca949a6f411d0fa3
Latest deploy log https://app.netlify.com/sites/evergreen-storybook/deploys/65cbc056d9ddec0008ae4300
Deploy Preview https://deploy-preview-1674--evergreen-storybook.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] avatar Feb 13 '24 19:02 netlify[bot]