evergreen icon indicating copy to clipboard operation
evergreen copied to clipboard

Published 20 hours ago • verified publisher icon segmentio

Upgrade @types/react dependency

Open zuhair-naqvi opened this issue 2 years ago • 2 comments

Any reason why "@types/react" is still set to "^16.9.5"? This will force developers to either add "skipLibCheck": true to their ts config OR add a "resolutions" field in order to resolve "duplicate identifier" errors with typescript if the rest of their packages (in a monorepo) use React 17 types

zuhair-naqvi avatar Aug 10 '21 00:08 zuhair-naqvi

Was an oversight as part of the React 17 upgrade -- PRs welcome! I'm also wondering if we even need to install @types/react alongside Evergreen, and instead push that responsibility to the consumers. 🤔

akleiner2 avatar Aug 10 '21 01:08 akleiner2

@akleiner2 cheers, PR issued

zuhair-naqvi avatar Aug 11 '21 00:08 zuhair-naqvi

In https://github.com/segmentio/evergreen/releases/tag/v7.1.0, we've removed this as a prod dependency. Feel free to open a new issue if you're still seeing discrepancies.

brandongregoryscott avatar Feb 02 '23 13:02 brandongregoryscott