analytics.js-integrations icon indicating copy to clipboard operation
analytics.js-integrations copied to clipboard

HGI 81 - Add event ID to page calls sent to FB Pixel for deduplication

Open sayan-das-in opened this issue 2 years ago • 1 comments

What does this PR do? In Facebook Pixel and Facebook Conversions API (Actions) integrations, the eventId parameter is used to dedupe events, however Segment doesn't send eventId for Facebook Pixel Page events. This PR maps AJS messageId to Facebook's eventId.

Are there breaking changes in this PR? No, this is a bug fix

Testing

Testing completed successfully in local environment with event tester Facebook Pixel Dashboard

Any background context you want to provide?

Is there parity with the server-side/android/iOS integration components (if applicable)? This PR is a bug fix which brings parity to Facebook Pixel Page Calls with Page Calls from Facebook Conversion API.

Does this require a new integration setting? If so, please explain how the new setting works No

Links to helpful docs and other external resources https://docs.google.com/document/d/19-PjSYJTH5tmKptMPXLBXPz3oF9c7sUpCSZ4TdyPYts

sayan-das-in avatar Sep 26 '22 16:09 sayan-das-in

@sayan-das-in The code looks good, but I think we should add at least one unit test to validate the new behavior/prevent future regressions. Thanks!

brennan avatar Sep 27 '22 16:09 brennan

Hi there,

I came across this PR by accident today, because we also have the deduplication problem. It would be extremely helpful for us to publish this fix, because we currently also have the deduplication issue for Facebook.

Are there any plans when this will be released? Thanks for your work! :)

jony1993 avatar Nov 29 '22 15:11 jony1993

@pooyaj @Innovative-GauravKochar Thanks for merging it.

Maybe a stupid question, but when and how is it released? We are using the "Segment snippet" and Facebook Pageview Events are still duplicated...

jony1993 avatar Dec 12 '22 16:12 jony1993

Hey @jony1993 - We are working on releasing it. The rollout is expected to be completed by 1-2 days. I will keep you posted.

varadarajan-tw avatar Dec 12 '22 16:12 varadarajan-tw

Hey @jony1993 - The changes should be available now. You can go ahead and test them.

varadarajan-tw avatar Dec 15 '22 05:12 varadarajan-tw

Hey @varadarajan-tw Thanks. Seems to be working now :)

jony1993 avatar Dec 15 '22 11:12 jony1993