Specify charset in Segment content-type header

Open acordiner opened this issue 5 years ago • 1 comments

What does this PR do?

Explicitly specifies a charset in the content-type header for the Segment integration.

Are there breaking changes in this PR?

Any background context you want to provide?

The Segment integration is sending a JSON payload with a content-type of text/plain. According to the HTTP spec, when no explicit charset is provided for text/plain payloads, a default charset value of ISO-8859-1 is assumed. However, the JSON payload is being encoded via XMLHttpRequest.send(), which uses UTF-8. Therefore, the charset should be explicitly specified as UTF-8.

Is there parity with the server-side/android/iOS integration components (if applicable)?

Unsure if applicable

Does this require a new integration setting? If so, please explain how the new setting works

Links to helpful docs and other external resources

XMLHttpRequest spec: "If body is a Document, then set request body to body, serialized, converted, and UTF-8 encoded." (https://xhr.spec.whatwg.org/#the-send()-method)
HTTP spec: "When no explicit charset parameter is provided by the sender, media subtypes of the "text" type are defined to have a default charset value of "ISO-8859-1" when received via HTTP." (https://www.w3.org/Protocols/rfc2616/rfc2616-sec3.html)

Sep 15 '20 12:09 acordiner

Any chance to get this merged?

Sep 27 '20 23:09 acordiner