analytics-next icon indicating copy to clipboard operation
analytics-next copied to clipboard

Improved error message logging in console

Open arielsilvestri opened this issue 3 years ago • 2 comments

Adds a console error with the error status text from the API explaining to users what went wrong with the settings call.

Screen Shot 2022-08-03 at 12 57 19 PM .

arielsilvestri avatar Aug 09 '22 15:08 arielsilvestri

🦋 Changeset detected

Latest commit: 9fb8918b316e588e6433daafc87aebadfc00f08b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@segment/analytics-next Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 09 '22 15:08 changeset-bot[bot]

We may need to update all the tests that use mock fetch to use more robust HTTP mock, since it's checking for OK see my comment: https://github.com/segmentio/analytics-next/pull/573#discussion_r941597513 image

Another reason why using nock / msw is in general a recommended approach over mocking fetch.

silesky avatar Aug 09 '22 17:08 silesky