analytics-next icon indicating copy to clipboard operation
analytics-next copied to clipboard

Signals sampling

Open danieljackins opened this issue 1 year ago • 4 comments

  • [ ] I've included a changeset (psst. run yarn changeset. Read about changesets here).

danieljackins avatar Oct 08 '24 16:10 danieljackins

🦋 Changeset detected

Latest commit: b8c6586766079aee300929137eb4f27ad7a07f93

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@segment/analytics-next Minor
@segment/analytics-signals Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Oct 08 '24 16:10 changeset-bot[bot]

@silesky does this method of cancelling signals make sense? Should the plugin be deregistered too?

danieljackins avatar Oct 08 '24 16:10 danieljackins

@danieljackins can we have a test / maybe an integration test for this?

silesky avatar Oct 08 '24 17:10 silesky

Plan Error

running git merge -q --no-ff -m atlantis-merge FETCH_HEAD: Auto-merging packages/signals/signals-integration-tests/src/helpers/base-page-object.ts
CONFLICT (content): Merge conflict in packages/signals/signals-integration-tests/src/helpers/base-page-object.ts
Auto-merging packages/signals/signals/src/core/client/__tests__/client.test.ts
Auto-merging packages/signals/signals/src/core/client/index.ts
Automatic merge failed; fix conflicts and then commit the result.
: exit status 1

seg-atlantis-prod[bot] avatar Oct 11 '24 03:10 seg-atlantis-prod[bot]