analytics-ios icon indicating copy to clipboard operation
analytics-ios copied to clipboard

Allow userId to be nullable on identify for iOS

Open danielgomezrico opened this issue 2 years ago • 4 comments

What does this PR do? Allow that userId to be null on identify

How should this be manually tested? Call identify with userId null, like:

[[SEGAnalytics sharedAnalytics] identify: null traits: {"something": "other"}];

It throws an exception:

[NSNull length]: unrecognized selector sent to instance 0x1db450558

Fix https://github.com/segmentio/analytics-ios/issues/1024

Screenshots or screencasts (if UI/UX change) On docs the userId is defined as optional https://segment.com/docs/connections/sources/catalog/libraries/mobile/ios/#identify image

danielgomezrico avatar Dec 17 '21 22:12 danielgomezrico

@prayansh Hi, Im not sure why the CI fails here, it looks like it is a configuration error from the repo, can we merge this? it is pretty important for our company to allow this fast

danielgomezrico avatar Dec 20 '21 10:12 danielgomezrico

@prayansh ping

danielgomezrico avatar Jan 18 '22 00:01 danielgomezrico

Hey @wenxi-zeng, any chance this can get merged real quick?

HerrNiklasRaab avatar Mar 01 '22 15:03 HerrNiklasRaab

👀 ping

danielgomezrico avatar Jan 10 '23 21:01 danielgomezrico