analytics-go icon indicating copy to clipboard operation
analytics-go copied to clipboard

switch to a maintained uuid library

Open thaJeztah opened this issue 6 years ago • 5 comments

The github.com/xtgo/uuid library has not been updated since 5 years, and may well be buggy. Use the google/uuid library instead, which is actively maintained, tested, and widely in use (e.g., in Docker, Kubernetes).

I based this on top of https://github.com/segmentio/analytics-go/pull/151, and will rebase once that is merged

thaJeztah avatar Apr 14 '19 18:04 thaJeztah

@williamgrosset @justincormack PTAL

thaJeztah avatar Apr 14 '19 18:04 thaJeztah

Thanks for the PR. Same as what I mentioned in #149, the master branch contains code for the v2 version which has been deprecated and is no longer maintained.

f2prateek avatar Apr 14 '19 19:04 f2prateek

I'll update this one against the V3 branch

thaJeztah avatar Apr 14 '19 19:04 thaJeztah

updated, but looked like there were issues with the vendor directory in the V3 branch as well, so opened https://github.com/segmentio/analytics-go/pull/151, and based this one on top of that

thaJeztah avatar Apr 14 '19 23:04 thaJeztah

Hi @f2prateek and @williamgrosset, did you have a chance to look at this PR?

ob1dev avatar Sep 06 '19 21:09 ob1dev