action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[STRATCONN-5473] Add destinationInstanceID and subscriptionId to support audience fanout for Liveramp Audiences

Open itsarijitray opened this issue 9 months ago • 1 comments

JIRA: https://segment.atlassian.net/browse/STRATCONN-5473

Accommodate subscriptionId as part of file path to support audience fanout for Liveramp.

Refer: https://docs.google.com/document/d/1Fx_vcI_VEbJPhm3tUprAFSvj7UCB9mxkW5ZVTmm5Nrs/edit?usp=sharing

Testing

Testing on stage As you can see, S3 file is now getting created with the new file format: Screenshot 2025-03-12 at 4 39 49 PM Screenshot 2025-03-12 at 4 40 03 PM Screenshot 2025-03-12 at 4 40 24 PM

  • [ ] Added unit tests for new functionality
  • [x] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [x] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

itsarijitray avatar Mar 10 '25 13:03 itsarijitray

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 77.57%. Comparing base (0689da0) to head (2389522). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ions/liveramp-audiences/audienceEnteredS3/index.ts 33.33% 2 Missing :warning:
...ns/liveramp-audiences/audienceEnteredSftp/index.ts 33.33% 2 Missing :warning:
...s/src/destinations/liveramp-audiences/awsClient.ts 50.00% 0 Missing and 2 partials :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2786      +/-   ##
==========================================
+ Coverage   77.41%   77.57%   +0.15%     
==========================================
  Files        1044     1044              
  Lines       19207    19209       +2     
  Branches     3749     3746       -3     
==========================================
+ Hits        14870    14902      +32     
+ Misses       3034     2995      -39     
- Partials     1303     1312       +9     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Mar 10 '25 13:03 codecov[bot]