Braze regions server

[davidbielik]

Adds new regions to braze server destinations

Testing

• [ ] Added unit tests for new functionality
• [x] Tested end-to-end using the local server
• [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [ ] [Segmenters] Tested in the staging environment
• [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[davidbielik]

@brennan can we get this merged please?

[davidbielik]

@marinhero any suggestions on what I need to do? Tests pass for me

[marinhero]

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

[marinhero]

Also, looks like this was opened right in the middle of our node 22 update. Make sure you pull the latest version of the repo so that version of the CI checks can run.

[davidbielik]

Ah! I think the test snapshot might be out of date. Let's try these instructions. Let me know how it goes!

Do you have a public link?

[marinhero]

@davidbielik Here it is: https://github.com/segmentio/action-destinations/blob/main/docs/testing.md#snapshot-testing

[marinhero]

Hi @davidbielik, just checking in as the next deploy is scheduled for Tuesday April 8th and would be great to have this to be a part of it. LMK if you have any questions, I'll be happy to help. Best.

[davidbielik]

@marinhero I ran that command but no files change:

[marinhero]

Tagging this weeks on-call to look into it @sayan-das-in

[marinhero]

@davidbielik this appears to be a TZ issue. We either freeze the timezone within the tests or leave the prior value of the snapshot "2021-02-01". Freezing might be better for long term but keeping the old value will be a much quicker fix.

[davidbielik]

@davidbielik this appears to be a TZ issue. We either freeze the timezone within the tests or leave the prior value of the snapshot "2021-02-01". Freezing might be better for long term but keeping the old value will be a much quicker fix.

Thanks - reverted date to the previous value.

[joe-ayoub-segment]

Hi @marinhero, FYI I'm back so can run with this PR.

[joe-ayoub-segment]

Tests pass locally and in CI. validate passes. Linter is complaining about this:

I'm going to create a new PR without this assertion, and will label it ready for deploy. I'll then close this PR.

[davidbielik]

Thanks @joe-ayoub-segment i removed those lines if that's easier

[joe-ayoub-segment]

New PR created here

Closing this PR.