action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Increasing timeout for Google Campaign Manager 360 (https://github.com/segmentio/eks-configuration/pull/7957 follow-up)

Open seg-leonelsanches opened this issue 10 months ago • 1 comments

Increasing timeout for Google Campaign Manager 360 (https://github.com/segmentio/eks-configuration/pull/7957 follow-up)

Testing

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [ ] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

seg-leonelsanches avatar Jan 30 '25 22:01 seg-leonelsanches

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 78.50%. Comparing base (52537f3) to head (24b7644). Report is 146 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2715      +/-   ##
==========================================
+ Coverage   78.46%   78.50%   +0.03%     
==========================================
  Files        1036     1036              
  Lines       18771    18773       +2     
  Branches     3561     3561              
==========================================
+ Hits        14729    14738       +9     
+ Misses       2844     2836       -8     
- Partials     1198     1199       +1     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Jan 30 '25 22:01 codecov[bot]

Hi @seg-leonelsanches - just doing some tidy up here. Is this PR still something you want to progress? If yes, then we need to find someone to review. If not I'll close it.

joe-ayoub-segment avatar May 06 '25 11:05 joe-ayoub-segment