action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Node upgrade

Open sayan-das-in opened this issue 10 months ago • 1 comments

Upgrade node version to 20.18

Testing

Testing in progress.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [ ] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

sayan-das-in avatar Jan 28 '25 07:01 sayan-das-in

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 79.26%. Comparing base (56e9fc2) to head (4132911).

Files with missing lines Patch % Lines
...nations/pipedrive/pipedriveApi/pipedrive-client.ts 16.66% 5 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2706      +/-   ##
==========================================
+ Coverage   78.56%   79.26%   +0.70%     
==========================================
  Files        1036     1284     +248     
  Lines       18767    24682    +5915     
  Branches     3563     5109    +1546     
==========================================
+ Hits        14744    19565    +4821     
- Misses       2822     3910    +1088     
- Partials     1201     1207       +6     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jan 28 '25 12:01 codecov[bot]

hi @sayan-das-in I'm doing some PR tidy up. Can you please close this PR if you don't intend to progress it?

joe-ayoub-segment avatar May 06 '25 11:05 joe-ayoub-segment