action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[Schematic] added onDelete hook

Open jasdeepg opened this issue 11 months ago • 2 comments

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [ ] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

jasdeepg avatar Jan 22 '25 21:01 jasdeepg

is there a way for the end user to specify any additional metadata other than the userId? ideally they can specify the key we pass to our delete endpoint.

jasdeepg avatar Jan 23 '25 21:01 jasdeepg

👋 Segment team. Wanted to check on this PR and see if there's anything else you need from us on this. We'd love to get this merged when possible.

ryanechternacht avatar Feb 24 '25 20:02 ryanechternacht

hi @jasdeepg and @ryanechternacht,

Apologies for the lack of follow up on this PR. I've been on extended leave so coverage, however I'm back now. The code looks good to me. Is this PR something you'd still like to deploy? Regarding your question - the userId is the only field which gets passed.

Please let me know how you'd like to proceed. If I don't hear back I'll eventually close this PR.

Kind regards, Joe

joe-ayoub-segment avatar May 06 '25 12:05 joe-ayoub-segment

hi again @jasdeepg do you still want to proceed with this PR?

joe-ayoub-segment avatar May 14 '25 14:05 joe-ayoub-segment

@ryanechternacht thoughts?

jasdeepg avatar May 14 '25 14:05 jasdeepg

hi @jasdeepg and @ryanechternacht just checking if you will be progressing this PR? If not I'm going to close it.

Best regards, Joe

joe-ayoub-segment avatar Jun 06 '25 13:06 joe-ayoub-segment

hi @jasdeepg and @ryanechternacht do you want me to deploy this PR?

joe-ayoub-segment avatar Jun 23 '25 12:06 joe-ayoub-segment