Fix incorrect mapping in mixpanel destination
A summary of your pull request, including the what change you're making and why.
widthandheightwere incorrectly mapped toscreenfield.- Fix the error:
width->screen.width;height->screen.height
Testing
Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.
- [ ] Added unit tests for new functionality
- [ ] Tested end-to-end using the local server
- [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
- [ ] [Segmenters] Tested in the staging environment
- [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.
Hi @brennan -- I see you added a tag 2 weeks ago. Is there anything you need from me to move this forward?
Hi @spjtls9 apologies for the delay getting to this PR. I've been on extended leave but am back now.
Is this something you'd still like to deploy?
Kind regards, Joe
Hi @spjtls9 apologies for the delay getting to this PR. I've been on extended leave but am back now.
Is this something you'd still like to deploy?
Kind regards, Joe
yes, I would still like to deploy this change.
Thanks for confirming @spjtls9 . It will go out with the next deploy.
Thanks for confirming @spjtls9 . It will go out with the next deploy.
@joe-ayoub-segment sorry forgot about the process here.
Will this PR automatically merge when the deploy happens?
Hi @spjtls9 I'll merge the PR just before we run the deploy.
hi @spjtls9 PR deployed. Please confirm you are happy with the change.
hi @spjtls9 PR deployed. Please confirm you are happy with the change.
confirmed changes look good on my segment workspace. Thank you