action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Fix incorrect mapping in mixpanel destination

Open spjtls9 opened this issue 11 months ago • 1 comments

A summary of your pull request, including the what change you're making and why.

  • width and height were incorrectly mapped to screen field.
  • Fix the error: width -> screen.width; height -> screen.height

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [ ] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

spjtls9 avatar Jan 20 '25 20:01 spjtls9

Hi @brennan -- I see you added a tag 2 weeks ago. Is there anything you need from me to move this forward?

spjtls9 avatar Mar 06 '25 16:03 spjtls9

Hi @spjtls9 apologies for the delay getting to this PR. I've been on extended leave but am back now.

Is this something you'd still like to deploy?

Kind regards, Joe

joe-ayoub-segment avatar May 06 '25 12:05 joe-ayoub-segment

Hi @spjtls9 apologies for the delay getting to this PR. I've been on extended leave but am back now.

Is this something you'd still like to deploy?

Kind regards, Joe

yes, I would still like to deploy this change.

spjtls9 avatar May 06 '25 16:05 spjtls9

Thanks for confirming @spjtls9 . It will go out with the next deploy.

joe-ayoub-segment avatar May 07 '25 08:05 joe-ayoub-segment

Thanks for confirming @spjtls9 . It will go out with the next deploy.

joe-ayoub-segment avatar May 07 '25 08:05 joe-ayoub-segment

@joe-ayoub-segment sorry forgot about the process here.

Will this PR automatically merge when the deploy happens?

spjtls9 avatar May 13 '25 17:05 spjtls9

Hi @spjtls9 I'll merge the PR just before we run the deploy.

joe-ayoub-segment avatar May 14 '25 12:05 joe-ayoub-segment

hi @spjtls9 PR deployed. Please confirm you are happy with the change.

joe-ayoub-segment avatar May 21 '25 14:05 joe-ayoub-segment

hi @spjtls9 PR deployed. Please confirm you are happy with the change.

confirmed changes look good on my segment workspace. Thank you

spjtls9 avatar May 21 '25 17:05 spjtls9