add `Report Content Event` to customerio destination
- Add
Report Content Eventto customerio destination. - We also make sure it's ignored by
Track Event.
Testing
Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.
- [x] Added unit tests for new functionality
- [ ] Tested end-to-end using the local server
- [x] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
- [ ] [Segmenters] Tested in the staging environment
- [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.
hi @karngyan thanks for raising this PR.
Do you work for Customer.io? If so could you please email me from a work email to [email protected] so I can verify your email address?
If you don't work for Customer.io I'll have to reach out to them to have them review the PR as well.
Kind regards, Joe
Hi again @karngyan ,
The CI / Validate check is failing. Could you please run yarn types and commit the changes to your branch?
To help me understand the use-case for this PR a little, could you share information of the API docs for sending a "Report Content Event" request to Customer.io please? I want to ensure that any conventions with the other pre-existing Actions are continued with this new code.
Best regards, Joe
Hi @joe-ayoub-segment 👋
Thank you for reviewing the PR! Yes, I work at Customer.io. I’ll send you an email from my work address shortly for verification.
I’ll run yarn types and update the PR. Regarding the documentation, this is a relatively new feature available to a select group of users. I’ll reach out to our docs team to get the link for you - please give me a little time. It's okay to delay this merge a little.
Thanks, Karn
Just FYI we're going into a deploy freeze for the Xmas and New Years holidays, so this PR won't go out until the New Year.
hi @karngyan - are you still interested in getting this PR out? It might be best to catch up and discuss face to face. Please schedule a call here if you'd like to meet: https://calendly.com/joe_ayoub/
Hi @karngyan, were you able to connect with Joe? If so, and if you're still interested in merging this PR, please update with the requested changes, and we'll review the PR again within the next few weeks. Thank you.
Hi folks, Apologies for missing this.
I'll book some time with Joe in the coming weeks. I'll make sure we close it this quarter.
hi @karngyan I hope you are well.
Looks like this PR dropped through the cracks. Is it something you'd like to progress?
If so, how about a 30 minute sync to get it over the line? Here's my Calendly link.
I look forward to hearing from you. Joe
hi @karngyan PR deployed. Please confirm that you are happy with the change.