New APIs to destination actions and code improvements

[wtnelso]

Added 3 new Attentive APIs to destination actions. Additionally, abstracted the codebase to be more readable and modular for future enhancements.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

• [x] Added unit tests for new functionality
• [x] Tested end-to-end using the local server
• [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
• [ ] [Segmenters] Tested in the staging environment
• [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

[seg-atlantis-prod[bot]]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod[bot]]

Error parsing command: EOF found when expecting closing quote

[seg-atlantis-prod[bot]]

Atlantis commands can't be run on fork pull requests. To enable, set --allow-fork-prs or, to disable this message, set --silence-fork-pr-errors

[seg-atlantis-prod[bot]]

Error parsing command: EOF found when expecting closing quote

[joe-ayoub-segment]

Hi @wtnelso thanks - please ping me when you'd like me to rereview.

[wtnelso]

Hi @joe-ayoub-segment just pushed the commit. This is ready for review.

I also left some questions/comments above in the previous suggestions.

[joe-ayoub-segment]

hi @wtnelso - it might be quicker if we catch up in person to fix up this PR? Would you be available to catch up?

https://calendly.com/joe_ayoub/

Thanks, Joe

[joe-ayoub-segment]

hi @wtnelso just following up on this - are you still interested in getting this PR out? Best regards, Joe

[wtnelso]

Hi @joe-ayoub-segment apologies for the delay - was on pat leave since mid-Dec. I just scheduled a time for us to review this PR later this week.

[brennan]

@wtnelso, can you go ahead and resolve the merge conflicts in this PR? Were you also able to address all of Joe's concerns after connecting with him? Please confirm, and we'll review this PR again within two weeks of your confirmation. Thank you.

[wtnelso]

Hi @brennan apologies for the delay. I didn't get a notification of the comment.

I'm still unsure of my updates are correct and wanted to speak with Joe about them. I know he's been out so would you be able to connect?

[joe-ayoub-segment]

hi @wtnelso I hope you are well.

I'm back from extended leave now - and am reviewing all open PRs. Is this PR something you'd like to progress? Based on the comments it looks like the next step was going to be a face to face call. Would you still like to do this? If so here's my Calendly link. Otherwise let's go ahead and close this PR.

Kind regards, Joe

[wtnelso]

Hi @joe-ayoub-segment, welcome back

Yes, I'd still like to move this PR forward. I spoke with @brennan about it and he mentioned merging the PR conflicts was the next step, which I completed earlier this week. Let me know if there are still steps to take around that, if there are, then I can set up a call.

Cheers!

[joe-ayoub-segment]

Hi @wtnelso I've opened a new PR for this: https://github.com/segmentio/action-destinations/pull/2922

I tidied up a bunch of stuff. Next it needs testing and the unit tests need to be fixed.

I consolidated the 3 new Actions into a single Action.

[joe-ayoub-segment]

As discussed with Partner - closing this PR as we've opened an internal PR instead