action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Salesforce custom object external

Open seg-leonelsanches opened this issue 1 year ago • 3 comments

This modification:

  • Updates Salesforce base API from version v53 to v62;
  • Adds a new mapping to upsert a custom object by its Id.

Testing

  • [X] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [ ] [Segmenters] Tested in the staging environment
  • [ ] [Segmenters] [If applicable for this change] Tested for regression with Hadron.

seg-leonelsanches avatar Oct 07 '24 23:10 seg-leonelsanches

hi @brennan - This is a Salesforce PR raised by an SA, so passing this PR on to you so it can be triaged.

joe-ayoub-segment avatar Oct 16 '24 11:10 joe-ayoub-segment

New required fields detected

[!WARNING] Your PR adds new required fields to an existing destination. Adding new required settings/mappings for a destination already in production requires updating existing customer destination configuration. Ignore this warning if this PR is for a new destination with no active customers in production.

The following required fields were added in this PR:

  • Destination: Salesforce (Actions), Action Field(s):operation,customObjectName,externalIdField,externalIdValue

Add these new fields as optional instead and assume default values in perform or performBatch block.

github-actions[bot] avatar Oct 18 '24 23:10 github-actions[bot]

Codecov Report

:x: Patch coverage is 80.00000% with 5 lines in your changes missing coverage. Please review. :warning: Please upload report for BASE (main@078cbaa). Learn more about missing BASE report. :warning: Report is 316 commits behind head on main.

Files with missing lines Patch % Lines
...nations/salesforce/customObjectExternalId/index.ts 75.00% 2 Missing :warning:
.../src/destinations/dynamic-yield-audiences/index.ts 0.00% 1 Missing :warning:
.../destinations/loops/createOrUpdateContact/index.ts 80.00% 1 Missing :warning:
...tions/src/destinations/salesforce/sf-operations.ts 83.33% 0 Missing and 1 partial :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2485   +/-   ##
=======================================
  Coverage        ?   78.50%           
=======================================
  Files           ?     1037           
  Lines           ?    18812           
  Branches        ?     3576           
=======================================
  Hits            ?    14769           
  Misses          ?     2838           
  Partials        ?     1205           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 18 '24 23:10 codecov[bot]

hi @seg-leonelsanches just doing some tidy up - can we close this PR?

joe-ayoub-segment avatar May 06 '25 13:05 joe-ayoub-segment