action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[Braze] Add MultiStatus Response support

Open sayan-das-in opened this issue 1 year ago • 1 comments

This PR adds MultiStatus support to Actions Braze (Cloud Mode).

Testing

Tested locally and with unit tests.

  • [x] Added unit tests for new functionality
  • [x] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

sayan-das-in avatar Sep 19 '24 06:09 sayan-das-in

Codecov Report

Attention: Patch coverage is 90.90909% with 9 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@e4f699d). Learn more about missing BASE report. Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...estination-actions/src/destinations/braze/utils.ts 90.32% 2 Missing and 7 partials :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2423   +/-   ##
=======================================
  Coverage        ?   78.04%           
=======================================
  Files           ?      982           
  Lines           ?    17114           
  Branches        ?     3212           
=======================================
  Hits            ?    13356           
  Misses          ?     2688           
  Partials        ?     1070           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 19 '24 07:09 codecov[bot]

I see that you have added the multistatus to the V2 actions. Do you plan to also add it to the original (V1) actions?

maryamsharif avatar Sep 30 '24 20:09 maryamsharif

Hey Sayan, this seems like a sizable change and while you don't change the event-delivery side of things, reporting does change. Can you provide evidence of testing in Staging to make sure we all understand how the destination will change? An example can be found here.

+1 to Maryam's question.

marinhero avatar Sep 30 '24 23:09 marinhero

Hi @marinhero and @maryamsharif the change has been made to both the V1 and V2 Actions. Since the action definitions call methods defined in utils.ts, the change is made there.

sayan-das-in avatar Oct 01 '24 10:10 sayan-das-in

hi @sayan-das-in PR deployed

joe-ayoub-segment avatar Oct 08 '24 14:10 joe-ayoub-segment