action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

STRATCONN-4169 | Events to Klaviyo destination is failing for delivery

Open Innovative-GauravKochar opened this issue 1 year ago • 1 comments

This Pull request is to fix the event delivery issue in TrackEvent and OrderCompleted Actions of Klaviyo (Actions)due to time property. So we are converting the timestamp to ISO Format .To understand more about the problem and solution , Please do go through this testing doc here.

Jira ticket :- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?assignee=63617339fc0cc7a600b03c6b&selectedIssue=STRATCONN-4169

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [x] Added unit tests for new functionality
  • [x] Tested end-to-end using the local server
  • [x] [Segmenters] Tested in the staging environment . Please have a look here

Innovative-GauravKochar avatar Sep 17 '24 10:09 Innovative-GauravKochar

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.97%. Comparing base (38b04f6) to head (dca0321). Report is 67 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   83.18%   82.97%   -0.21%     
==========================================
  Files         932      948      +16     
  Lines       16238    16576     +338     
  Branches     3052     3135      +83     
==========================================
+ Hits        13507    13754     +247     
- Misses       2540     2628      +88     
- Partials      191      194       +3     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Sep 17 '24 10:09 codecov[bot]

hi @Innovative-GauravKochar PR deployed. Please confirm you are happy with the update.

joe-ayoub-segment avatar Oct 02 '24 11:10 joe-ayoub-segment

Thank you @joe-ayoub-segment for the deployment , it's working fine on prod.

Innovative-GauravKochar avatar Oct 03 '24 08:10 Innovative-GauravKochar