action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[google sheets] mark batch_size and batch_bytes are non-required field

Open varadarajan-tw opened this issue 1 year ago • 1 comments

Marks batch_size and batch_bytes as non-required fields. There are default values for these two fields even if the value is remain unset. So, it doesn't make sense to have these two are required fields.

Testing

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

varadarajan-tw avatar Sep 17 '24 05:09 varadarajan-tw

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.18%. Comparing base (571be20) to head (93fb6a6). Report is 407 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2405      +/-   ##
==========================================
- Coverage   83.38%   83.18%   -0.21%     
==========================================
  Files         964      932      -32     
  Lines       18000    16238    -1762     
  Branches     3554     3052     -502     
==========================================
- Hits        15010    13507    -1503     
+ Misses       2807     2540     -267     
- Partials      183      191       +8     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Sep 17 '24 05:09 codecov[bot]

Hi @varadarajan-tw just doing some tidy up - can we close this PR?

joe-ayoub-segment avatar May 06 '25 13:05 joe-ayoub-segment