Channels-1094 refactored
Refactoring changes of https://github.com/segmentio/action-destinations/pull/2024
Implementation of Dedup RFC
Testing
Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.
- [ ] Added unit tests for new functionality
- [ ] Tested end-to-end using the local server
- [ ] [Segmenters] Tested in the staging environment
Codecov Report
Attention: Patch coverage is 81.06509% with 64 lines in your changes missing coverage. Please review.
Project coverage is 78.36%. Comparing base (
ab536b3) to head (f201521). Report is 12 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #2325 +/- ##
==========================================
+ Coverage 77.94% 78.36% +0.42%
==========================================
Files 982 1035 +53
Lines 17059 19624 +2565
Branches 3208 3921 +713
==========================================
+ Hits 13297 15379 +2082
- Misses 2693 3169 +476
- Partials 1069 1076 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@joe-ayoub-segment I would like this to be deployed, but still waiting for approvals
@nick-Ag fixed it (it was easier to fix than I expected), plz review
hi @brennan there's some core changes in here. Do you want me to deploy this on Tuesday, or would you prefer that it's done by someone in the US during US working hours so that it can be monitored more closely?
@joe-ayoub-segment Please do not merge/deploy this PR as part of the regularly scheduled deploy on October 8. The on-call will deploy this separately in the late morning/early afternoon. Thank you.