action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Channels-1094 refactored

Open pmunin opened this issue 1 year ago • 1 comments

Integrations PR

Refactoring changes of https://github.com/segmentio/action-destinations/pull/2024

Implementation of Dedup RFC

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

pmunin avatar Aug 21 '24 23:08 pmunin

Codecov Report

Attention: Patch coverage is 81.06509% with 64 lines in your changes missing coverage. Please review.

Project coverage is 78.36%. Comparing base (ab536b3) to head (f201521). Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
...s-shared/src/engage/utils/EngageActionPerformer.ts 81.95% 34 Missing and 1 partial :warning:
...es/actions-shared/src/engage/utils/EngageLogger.ts 29.41% 12 Missing :warning:
...ns-shared/src/engage/utils/MessageSendPerformer.ts 90.74% 5 Missing :warning:
...messaging-sendgrid/sendEmail/SendEmailPerformer.ts 33.33% 3 Missing and 1 partial :warning:
.../actions-shared/src/engage/utils/AggregateError.ts 0.00% 3 Missing :warning:
...ges/actions-shared/src/engage/utils/EngageStats.ts 0.00% 3 Missing :warning:
...ssaging-twilio/__tests__/__helpers__/test-utils.ts 71.42% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2325      +/-   ##
==========================================
+ Coverage   77.94%   78.36%   +0.42%     
==========================================
  Files         982     1035      +53     
  Lines       17059    19624    +2565     
  Branches     3208     3921     +713     
==========================================
+ Hits        13297    15379    +2082     
- Misses       2693     3169     +476     
- Partials     1069     1076       +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 27 '24 19:08 codecov[bot]

@joe-ayoub-segment I would like this to be deployed, but still waiting for approvals

pmunin avatar Oct 01 '24 12:10 pmunin

@nick-Ag fixed it (it was easier to fix than I expected), plz review

pmunin avatar Oct 03 '24 21:10 pmunin

hi @brennan there's some core changes in here. Do you want me to deploy this on Tuesday, or would you prefer that it's done by someone in the US during US working hours so that it can be monitored more closely?

joe-ayoub-segment avatar Oct 04 '24 11:10 joe-ayoub-segment

@joe-ayoub-segment Please do not merge/deploy this PR as part of the regularly scheduled deploy on October 8. The on-call will deploy this separately in the late morning/early afternoon. Thank you.

brennan avatar Oct 07 '24 21:10 brennan