action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

channels-1094: Refactoring diffs

Open pmunin opened this issue 1 year ago • 3 comments

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

pmunin avatar Aug 21 '24 17:08 pmunin

Fixed the last batch of TypeScript issues. I think that if we're going to use patterns like this one we should be very strict with types and ensure that we're writing completely type complete code even though it increases the verbosity of our code. The language patterns you've introduced mirror very strongly typed languages and the more TS hacks we use the more likely it is to break.

cogwizzle avatar Aug 21 '24 20:08 cogwizzle

Codecov Report

Attention: Patch coverage is 96.82540% with 2 lines in your changes missing coverage. Please review.

Project coverage is 77.89%. Comparing base (d682103) to head (84f4fe8). Report is 73 commits behind head on channels-1094.

Files Patch % Lines
...ssaging-twilio/__tests__/__helpers__/test-utils.ts 71.42% 1 Missing and 1 partial :warning:
Additional details and impacted files
@@                Coverage Diff                @@
##           channels-1094    #2324      +/-   ##
=================================================
+ Coverage          77.47%   77.89%   +0.42%     
=================================================
  Files                905      944      +39     
  Lines              15584    17384    +1800     
  Branches            2853     3372     +519     
=================================================
+ Hits               12074    13542    +1468     
- Misses              2574     2904     +330     
- Partials             936      938       +2     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 21 '24 23:08 codecov[bot]

hi @pmunin @cogwizzle please let me know when this is ready for release.

joe-ayoub-segment avatar Aug 27 '24 08:08 joe-ayoub-segment

Closing towards https://github.com/segmentio/action-destinations/pull/2325

pmunin avatar Sep 24 '24 16:09 pmunin