action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

Capture and rethrow json.parse and strigify errors from @json directive

Open varadarajan-tw opened this issue 1 year ago • 1 comments

Recently noticed a spike in internal errors for actions-amplitude.

image

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

varadarajan-tw avatar Aug 19 '24 08:08 varadarajan-tw

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@c5b6298). Learn more about missing BASE report. Report is 494 commits behind head on main.

Files with missing lines Patch % Lines
packages/core/src/mapping-kit/index.ts 66.66% 2 Missing :warning:
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2303   +/-   ##
=======================================
  Coverage        ?   77.80%           
=======================================
  Files           ?      939           
  Lines           ?    17163           
  Branches        ?     3287           
=======================================
  Hits            ?    13354           
  Misses          ?     2889           
  Partials        ?      920           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Aug 19 '24 08:08 codecov[bot]

Hey @varadarajan-tw can we close this PR?

joe-ayoub-segment avatar May 06 '25 13:05 joe-ayoub-segment