action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

create audience and get audience methods

Open rvadera12 opened this issue 1 year ago • 1 comments

A summary of your pull request, including the what change you're making and why.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality
  • [ ] Tested end-to-end using the local server
  • [ ] [Segmenters] Tested in the staging environment

rvadera12 avatar Aug 06 '24 18:08 rvadera12

Codecov Report

Attention: Patch coverage is 31.25000% with 22 lines in your changes missing coverage. Please review.

Project coverage is 77.39%. Comparing base (a01e339) to head (a0e19e6).

Files Patch % Lines
...estinations/hubspot/upsertObject/dynamic-fields.ts 5.88% 16 Missing :warning:
...rc/destinations/dynamic-yield-audiences/helpers.ts 40.00% 3 Missing :warning:
...rc/destinations/hubspot/customEvent/hubspot-api.ts 0.00% 2 Missing :warning:
...destinations/hubspot/customEvent/dynamic-fields.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2250      +/-   ##
==========================================
- Coverage   77.40%   77.39%   -0.02%     
==========================================
  Files         899      899              
  Lines       15341    15343       +2     
  Branches     2802     2803       +1     
==========================================
  Hits        11874    11874              
- Misses       2554     2556       +2     
  Partials      913      913              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 13 '24 18:08 codecov[bot]

Hey @rvadera12 can we close this PR?

joe-ayoub-segment avatar May 06 '25 13:05 joe-ayoub-segment