segmentio
Evolv dest actions
A summary of your pull request, including the what change you're making and why.
Testing
Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.
- [ x ] Added unit tests for new functionality
- [ x ] Tested end-to-end using the local server
- [ ] [Segmenters] Tested in the staging environment
Hi @rcowin - thanks for raising the PR.
I didn't have time to do a proper review yet. I just scanned through the labels and descriptions and left some comments. I'll schedule some later this week to review properly.
Best regards, Joe
Oh yes @rcowin please note that some CI checks are failing. Could you take a look at this also?
hi @rcowin any chance you could address the failing CI checks before I do the review please?
hi @rcowin any chance you could address the failing CI checks before I do the review please?
I just updated the package size limit.
@joe-ayoub-segment is this the correct approach to resolve the size limit issue?
hi @rcowin any chance you could address the failing CI checks before I do the review please?
I just updated the package size limit.
@joe-ayoub-segment is this the correct approach to resolve the size limit issue?
Hi @rcowin thanks for your patience on this, it is the end of my day here, but I will be reviewing this tomorrow and get back to you. Meanwhile, if you have any questions or concerns, do let me know.
hi @rcowin any chance you could address the failing CI checks before I do the review please?
I just updated the package size limit.
@joe-ayoub-segment is this the correct approach to resolve the size limit issue?
hey @rcowin - I see that you bumped the size by 19 KBs. I was unable to see the previous CI error, but this should be only increased enough to pass the checks by a small margin.
The size limit isn’t meant to be a hard limit - it is just in place alert us in case the size increases by an unexpected amount. You should totally feel fine increasing the size limit as needed (and adding a buffer of around a kilobyte)
@tcgilbert build should be fixed. sorry - one of the files had incomplete update.
How do other optimization tools (VWO and Optimizely) send experiment confirmation events (or do they) as well as consume segment content?
hi @rcowin and @tcgilbert - just FYI there are a number of changes to other Destinations in this PR. Could they be removed please, even if they are just formatting changes?
@rcowin still seeing files unrelated to evolv-ai in the PR. Any file that does not live in the evolv-ai directory should be removed.
Perhaps it would be easier to create a new branch and pull request if the git commits are too tangled up at this point.