Updated delivr ai activate action destination from AWS S3 and SFTP server to delivr ai REST API

[erjakhar96]

Updated delivr ai activate action destination where customer can sync Segment.io audience to delivr.ai Audience segmentation and activate to delivr.ai supported destinations.

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

• [x] Added unit tests for new functionality
• [x] Tested end-to-end using the local server
• [x] [Segmenters] Tested in the staging environment

[tcgilbert]

@SunilPortqii I saw you made one change from the last review, did you see the other review comments? Once addressed we can move forward.

If you have any other questions or concerns, let me know. Additionally, if easier to discuss over a call, you can schedule time here: https://calendly.com/tgilbert-segment/segment-partner-call

[erjakhar96]

Hi @tcgilbert I made the changes suggested by you, please let me know if still anything missing I will schedule a call, Thanks

[tcgilbert]

Hey @SunilPortqii - Thanks for making those updates.

Last thing to take care of is ensuring the CI checks pass. Right now they are failing for this PR. Please ensure that your tests are passing, and that you have your types up to date. Here are some useful commands to:

# Update Types: 
./bin/run generate:types --path ./packages/destination-actions/src/destinations/delivrai-activate/index.ts

# Run Tests: 
yarn cloud test --testPathPattern=src/destinations/delivrai-activate

[erjakhar96]

Hi @tcgilbert I re-run the types update command, the test cases passed at my end, let me know if anything missing ,Thanks

[tcgilbert]

Hi @tcgilbert I re-run the types update command, the test cases passed at my end, let me know if anything missing ,Thanks

@erjakhar96 Okay great. Apologies but, one last update:

We’ve recently updated our CI checks for partner pull requests. Could you please pull from the main branch on your fork and merge the updates into your PR branch once more? This will allow us to run the CI checks with the new config again and ensure they pass.

[tcgilbert]

@erjakhar96 afraid the tests are still failing. Looks like the issue is with the types in the utils file:

• device_type
• seg_id

[erjakhar96]

Hi @tcgilbert I added the fix but on my end this command "yarn cloud test --testPathPattern=src/destinations/delivrai-activate" gives all passed any other command that I am missing

[tcgilbert]

hey @erjakhar96 - The CI is still failing, but I understand the issue now.

Essentially, you can't manually add types to the generated types file if they do not exist as a field in the action. With that in mind, you will need to decide if you want to ingest device_type in the action. If you do, then you will need to add a field for it. If not then you will need to remove this from the code.

If you have any other questions or concerns, let me know.

[erjakhar96]

Thanks, @tcgilbert for highlight the issue , we added device type field , please verify , Thanks

[joe-ayoub-segment]

hi @erjakhar96 and @tcgilbert this PR has been deployed. Thomas are you OK taking care of moving to Private Beta, etc?