segmentio
channels-1094
refactor: Refactoring the name for dataFeedCache to be engageDestinationCache. This is because this cache is no longer just intended to be used for DataFeed cache, but is now intended to be used as a more generic cache for the Engage Destination.
A summary of your pull request, including the what change you're making and why.
Testing
The changes should be tested in the PR in integrations. Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.
This change was tested in conjunction with the Channels-1094 branch in integrations. We saw 2000 duplicates prevented during our load test. Additionally we had 624 duplicates that still showed up in Splunk. In prior load test of the same size this number was close to 3000.
- [ ] Added unit tests for new functionality
- [ ] Tested end-to-end using the local server
- [ ] [Segmenters] Tested in the staging environment
hi @cogwizzle @pmunin please let me know when you are done with this so I can review prior to deploy
hi @cogwizzle - there's a bunch of failing CI checks. Can you address these before I review please?
hi @cogwizzle - there's a bunch of failing CI checks. Can you address these before I review please?
Fixed the test and pipeline.
hi @cogwizzle - converting to draft until this is ready for review.
