segmentio
channels-1084: LiquidJS dependency update.
Updating version of liquidjs.
https://segment.atlassian.net/browse/CHANNELS-1084
Testing
Should be a transparent yarn test command to ensure the functionality continues to work as expected. Based on coverage reports running the code locally all instances of the liquidjs library have been run through multiple rounds of testing.
- [ ] Added unit tests for new functionality
- [ ] Tested end-to-end using the local server
- [ ] [Segmenters] Tested in the staging environment
hi @cogwizzle Can you add some proof of testing to the PR please? I won't be the person deploying it next week as I'll be on PTO
hi @cogwizzle Can you add some proof of testing to the PR please? I won't be the person deploying it next week as I'll be on PTO
I was able to merge onto stage and test via test message flow. I performed liquid variable replacements successfully on email and SMS. This is in addition to the thousands of runs through via the test suite.
Thank you!
On Tue, May 07, 2024 at 09:10:05AM UTC, Varadarajan V wrote:
Hey @cogwizzle , PR has been deployed!
-- Reply to this email directly or view it on GitHub: https://urldefense.com/v3/https://github.com/segmentio/action-destinations/pull/2013*issuecomment-2098819941;Iw!!NCc8flgU!a9N-MfukWkK680OgFdMX-8xQLSk_Wi5IIQc7M4vw0yAg5eBXtx-QNU7xS-dzE2r7rTW8tQ88-VPd18McMgeBeKhU$ You are receiving this because you were mentioned.
Message ID: @.***>