action-destinations icon indicating copy to clipboard operation
action-destinations copied to clipboard

[Stratconn-2879] | Set up DataDog dashboard to track requests to Oauth Supported Destinations.

Open Innovative-GauravKochar opened this issue 1 year ago • 2 comments

This Pull request is to set up DataDog dashboard to track requests to Oauth Supported Destinations. Jira Ticket:- https://segment.atlassian.net/jira/software/c/projects/STRATCONN/boards/310?modal=detail&selectedIssue=STRATCONN-2879&assignee=63617339fc0cc7a600b03c6b

Testing

Include any additional information about the testing you have completed to ensure your changes behave as expected. For a speedy review, please check any of the tasks you completed below during your testing.

  • [ ] Added unit tests for new functionality - Not Required
  • [ ] Tested end-to-end using the local server - Not Required
  • [ ] [Segmenters] Tested in the staging environment -

Innovative-GauravKochar avatar Sep 18 '23 08:09 Innovative-GauravKochar

@Innovative-GauravKochar Thank you for putting all this together! After seeing how many changes oauth metrics tracking entails, I think I'd prefer to extract LinkedIn into its own PR and merge/deploy that first so we limit the blast radius of the change. Once we get signal on how useful metrics are for LinkedIn, then we can move forward with adding metrics to the other destinations.

@Innovative-GauravKochar is it possible to set up a PR with only the changes to LinkedIn sometime this week? Thank you again!

brennan avatar Sep 25 '23 22:09 brennan

@brennan Created a Seperate PR for linkedin-audiences https://github.com/segmentio/action-destinations/pull/1619

Innovative-GauravKochar avatar Sep 28 '23 07:09 Innovative-GauravKochar

should we close this in favor of https://github.com/segmentio/integrations/pull/2920?

varadarajan-tw avatar Jul 18 '24 06:07 varadarajan-tw

Closing in favour of https://github.com/segmentio/integrations/pull/2920

Innovative-GauravKochar avatar Jul 18 '24 07:07 Innovative-GauravKochar