kafka-lag-exporter icon indicating copy to clipboard operation
kafka-lag-exporter copied to clipboard

Added annotation support to 031-MountedSecret.yaml

Open jmjones-figure opened this issue 4 years ago • 7 comments

This pull request adds the ability to include annotations to the mounted secrets. This is required for the argo vault plugin that we are currently using.

kind: Secret
apiVersion: v1
metadata:
  name: example-secret
  annotations:
    avp.kubernetes.io/path: "path/to/secret"
type: Opaque
data:
  password: <password-vault-key>

jmjones-figure avatar Mar 14 '22 22:03 jmjones-figure

Thanks. Please merge master to run CI.

seglo avatar Mar 26 '22 21:03 seglo

I resolved the conflicts for this PR

jmjones-figure avatar May 26 '22 16:05 jmjones-figure

@seglo I do not have write access to merge this PR. Can you approve and merge?

jmjones-figure avatar Jun 01 '22 18:06 jmjones-figure

@jmjones-figure How come you included a chart release workflow? This is redundant with the existing release workflow and is something I trigger manually.

If you remove this I'll merge and publish a release.

seglo avatar Jun 04 '22 15:06 seglo

@seglo I did not mean to do that. How do I remove the chart release workflow?

jmjones-figure avatar Jun 06 '22 20:06 jmjones-figure

@seglo never mind I will remove it.

jmjones-figure avatar Jun 06 '22 20:06 jmjones-figure

@seglo Can you merge this PR?

jmjones-figure avatar Aug 08 '22 21:08 jmjones-figure

Closing this in favour of a PR with a branch I can update #383

seglo avatar Aug 27 '22 15:08 seglo