radiobrowser icon indicating copy to clipboard operation
radiobrowser copied to clipboard

DELETE, UNDELETE and REVERT are HIDDEN for now

Open davidhedlund opened this issue 7 years ago • 7 comments

  • I deleted a station for test purpose that I was going to restore. I can press the Delete button but it isn't deleted from the database.
  • [http://www.radio-browser.info/gui/#/deleted Deleted] is totally empty.

davidhedlund avatar Feb 04 '18 03:02 davidhedlund

There is a message on http://www.radio-browser.info/gui/#/ i deactivated delete, revert and undelete. i got a disturbing message from a user who reported, that the wrong stations got deleted. i did not find the cause yet, but i am also working on a complete rewrite for a few weeks now. i want to port the apache/php part to rust. mainly for speed, type checks. it will have compatible API calls. but i also want to support multi server sync in the future to keep up with demand. that is why i did not spend too much time with finding the bug. why did you want to delete the station? did you have similiar experiences with wrong stations deleted in the past?

segler-alex avatar Feb 04 '18 10:02 segler-alex

There is a message on http://www.radio-browser.info/gui/#/

Thanks.

i did not find the cause yet, but i am also working on a complete rewrite for a few weeks now. i want to port the apache/php part to rust. mainly for speed, type checks. it will have compatible API calls.

I'm glad to hear this, I wish you all the best.

why did you want to delete the station?

I wanted to delete (with the intention to use the Undelete function later) the station to verify an old bug that I submitted. RadioDroid already excludes Broken stations from the lists so it wouldn't make sense do "Delete" one of them, I simply had to pick a fresh station. Besides, I tried to delete one of the stations I listen most to so there's no way that I was going to forget to restore it. I wold have performed the same test if I was the owner of this project myself.

There's nothing to worry about here, I just want to maintain my bug reports. I'm a also a free software developer.

did you have similiar experiences with wrong stations deleted in the past?

No.

davidhedlund avatar Feb 04 '18 17:02 davidhedlund

Can you please temporarily hide:

  • The "Delete" button from edit mode (example page)
  • Top menu: "Needs help" -> "Deleted"

davidhedlund avatar Feb 04 '18 17:02 davidhedlund

this is a good idea, done

segler-alex avatar Feb 04 '18 17:02 segler-alex

You have added back the Delete. Thank you.

Please close this issue once you've fixed this:

Remove text

I think you want to remove the text from the main page http://www.radio-browser.info/gui/#/ :

UNDELETE and REVERT are DISABLED for now. It caused some data corruption which is still beeing investigated.

And remove the red font color for this text:

ADD, EDIT and VIEW is still online and can be used without problems.

davidhedlund avatar Mar 21 '18 13:03 davidhedlund

Fixed, thank you.

davidhedlund avatar Apr 23 '18 20:04 davidhedlund

Should "Needs help -> Deleted" in the top menu be restored?

davidhedlund avatar Apr 23 '18 20:04 davidhedlund